Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations from pointset #4439

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

MatthewFlamm
Copy link
Contributor

Overview

CallableBool was added in #1602.

number of faces starting raising an error for removal purposes in #1213

This is related to #4389, and might be recommended to merge after some time has passed to avoid any conflicts with patch changes, although the changes here are less likely to cause problems in my opinion.

@github-actions github-actions bot added documentation Anything related to the documentation/website maintenance Low-impact maintenance activity labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #4439 (485318d) into main (ae6a914) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4439      +/-   ##
==========================================
- Coverage   95.83%   95.83%   -0.01%     
==========================================
  Files          97       97              
  Lines       20912    20910       -2     
==========================================
- Hits        20041    20039       -2     
  Misses        871      871              

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd prefer smaller PRs to make these changes easier to track.

Absolutely love getting rid of CallableBool.

@MatthewFlamm MatthewFlamm changed the title Remove additional deprecations Remove deprecations from pointset May 21, 2023
@tkoyama010 tkoyama010 merged commit b112597 into main May 22, 2023
24 checks passed
@tkoyama010 tkoyama010 deleted the maint/remove-CallableBool branch May 22, 2023 00:03
@banesullivan banesullivan mentioned this pull request Jun 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants