changed docstring for extract_all_edges() argument use_all_points #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4470 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 97 97
Lines 20910 20910
=======================================
Hits 20039 20039
Misses 871 871 |
banesullivan
approved these changes
May 30, 2023
|
Thank you @banesullivan and @tkoyama010 for your responsiveness! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR corrects a small docstring error on an argument of the method
extract_all_edges.9bf77ed#r115259241
Details
According to VTK source code, https://gitlab.kitware.com/vtk/vtk/-/blob/master/Filters/Core/vtkExtractEdges.cxx, lines 432-438 and 332-338, point renumbering does not happen when
use_all_point=True. The method's docstring has been modified accordingly.