Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cell center property #4480

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Add Cell center property #4480

merged 5 commits into from
Jun 7, 2023

Conversation

MatthewFlamm
Copy link
Contributor

Overview

Adds property for the center of a cell. This returns a different type of center compared to DataSet.center which is the center of hte bounding box. This property returns the center of the cell from the parameterized coordinates within the cell.

Details

See https://vtk.org/doc/nightly/html/classvtkCell.html#ae6d79848c5b56865eadac6bebbe723a1

For consistency, I changed all examples to use import pyvista as pv in this class.

@github-actions github-actions bot added the enhancement Changes that enhance the library label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #4480 (67cc2b2) into main (bb02641) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4480   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         107      107           
  Lines       21026    21035    +9     
=======================================
+ Hits        20113    20122    +9     
  Misses        913      913           

pyvista/core/cell.py Outdated Show resolved Hide resolved
pyvista/core/cell.py Outdated Show resolved Hide resolved
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010 tkoyama010 marked this pull request as draft June 1, 2023 23:52
@tkoyama010
Copy link
Member

Please hold off merging until we merge #4486 and resolve the conflict with it.

@banesullivan banesullivan marked this pull request as ready for review June 7, 2023 13:26
@banesullivan banesullivan merged commit 4d75788 into main Jun 7, 2023
24 checks passed
@banesullivan banesullivan deleted the feat/Cell-center branch June 7, 2023 17:26
@banesullivan banesullivan mentioned this pull request Jun 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants