Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VTK cell type to pyvista.CellType #4485

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Move VTK cell type to pyvista.CellType #4485

merged 5 commits into from
Jun 8, 2023

Conversation

beroda
Copy link
Contributor

@beroda beroda commented Jun 1, 2023

Resolves #4440

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 1, 2023
tkoyama010
tkoyama010 requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks working for this!

tests/check_doctest_names.py Outdated Show resolved Hide resolved
@beroda @tkoyama010
Update tests/check_doctest_names.py
1dd291b 
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
@beroda
Copy link
Contributor Author

beroda commented Jun 1, 2023

@tkoyama010 Glad to help a little

@beroda beroda closed this Jun 1, 2023
@beroda beroda reopened this Jun 1, 2023
tkoyama010
tkoyama010 previously approved these changes Jun 1, 2023
View reviewed changes
@tkoyama010 tkoyama010 changed the title move vtk cell type to pyvista.cell type Move vtk cell type to pyvista.cell type Jun 1, 2023
@adeak adeak changed the title Move vtk cell type to pyvista.cell type Move VTK cell type to pyvista.CellType Jun 1, 2023
@tkoyama010 tkoyama010 marked this pull request as draft June 1, 2023 23:51
@tkoyama010
Copy link
Member

Please hold off merging until we merge #4486 and resolve the conflict with it.

@codecov
Copy link

codecov bot commented Jun 4, 2023 •
edited

Codecov Report

Merging #4485 (558706a) into main (4d75788) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4485   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         107      107           
  Lines       21035    21035           
=======================================
  Hits        20122    20122           
  Misses        913      913

@banesullivan
Copy link
Member

@beroda, I just landed a rather significant refact that impacted this PR. Would you please rebase off main?

@tkoyama010 tkoyama010 marked this pull request as ready for review June 7, 2023 20:34
@banesullivan banesullivan merged commit 90bda64 into pyvista:main Jun 8, 2023
22 checks passed
@banesullivan banesullivan mentioned this pull request Jun 30, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoyama010 tkoyama010 tkoyama010 approved these changes

@banesullivan banesullivan banesullivan approved these changes

Assignees
No one assigned
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move vtk CELL_TYPE to pyvista.CellType
3 participants
@beroda @tkoyama010 @banesullivan