-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding append_polydata method #4489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4489 +/- ##
=======================================
Coverage 95.65% 95.66%
=======================================
Files 107 107
Lines 21035 21048 +13
=======================================
+ Hits 20122 20135 +13
Misses 913 913 |
Thank you for adding this. Please hold off merging until we merge #4486 and resolve the conflict with it. |
akaszynski
reviewed
Jun 6, 2023
akaszynski
reviewed
Jun 6, 2023
akaszynski
reviewed
Jun 6, 2023
akaszynski
reviewed
Jun 6, 2023
banesullivan
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR originates from comments #4227 (comment) and #4227 (comment).
Since #4227 replaced
vtkAppendPolyDataFilter
byDataSetFilters.merge
inPolyDataFilters.merge
to greatly improve performance and coherence with other merging operations, points ordering is altered and can cause some users to face issues.This PR is not a roll-back of #4227 since it simply adds a
PolyDataFilter.append_polydata
method re-implementingvtkAppendPolyDataFilter
.A note regarding this change of behavior for
0.39.0
is also added in the documentation ofPolyDataFilters.merge
for users experiencing the same issues.Details