Deprecate pyvista.utilities #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4507 +/- ##
==========================================
+ Coverage 95.71% 95.75% +0.03%
==========================================
Files 107 126 +19
Lines 21066 21094 +28
==========================================
+ Hits 20164 20198 +34
+ Misses 902 896 -6 |
annehaley
reviewed
Jun 9, 2023
banesullivan
added
the
deprecation
adeak
reviewed
Jun 10, 2023
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
adeak
reviewed
Jun 10, 2023
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
adeak
reviewed
Jun 12, 2023
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
banesullivan
commented
Jun 13, 2023
adeak
reviewed
Jun 13, 2023
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
adeak
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks for bearing with me @banesullivan @akaszynski. Looks great to me now.
|
Always appreciate your attention to detail @adeak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4486 to properly deprecate the
pyvista.utilitiesmodule and test that this API is still useable (non-breaking) but does issue deprecation warnings.This whole thing feels hacky, I'm open to suggestions on other ways to do this