Validate and clean up pyvista.plotting namespace #4508
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4508 +/- ##
==========================================
+ Coverage 95.66% 95.72% +0.05%
==========================================
Files 107 107
Lines 21048 21054 +6
==========================================
+ Hits 20135 20153 +18
+ Misses 913 901 -12 |
|
|
||
| from pyvista.core.errors import PyVistaDeprecationWarning | ||
|
|
||
| namesapce_data = pathlib.Path(__file__).parent / 'namespace-plotting.txt' |
There was a problem hiding this comment.
Just a style nitpick, but it might be better form to put this block of code in a function which gets called in parametrize() later. Unlikely that this test module will be imported, but still having this code in the global scope is a bit weird.
There was a problem hiding this comment.
I tend to let these sort of things slide in testing modules as no matter what, this code will have to run immediately on import or not. Maybe I wait until all PRs affecting this namespace testing directory are finished since this same logic repeats itself in three files now and make this reading/parameterizing one function in the conftest
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Follow up to #4486 to validate the changes did not break
from pyvista.plotting import <feature>imports. I added tests that validate against the namespace in the last release but I did remove things that I did not think were intentionally exposed (which was quite a bit of stuff because of previous*imports).