Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clamping/range to the glyph filter #451

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR adds two parameters clamping and rng (for range) to improve the flexibility of the glyph filter.

@banesullivan
Copy link
Member

Strange error when building the docs... I just restarted those jobs

@banesullivan
Copy link
Member

banesullivan commented Nov 18, 2019

So this is the error we're getting across branches. Looks like a sphinx-gallery issue?

# Sphinx version: 2.2.1
# Python version: 3.7.3 (CPython)
# Docutils version: 0.15.2 release
# Jinja2 version: 2.10.3
# Last messages:

# Loaded extensions:
Traceback (most recent call last):
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx/cmd/build.py", line 275, in build_main
    args.tags, args.verbosity, args.jobs, args.keep_going)
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx/application.py", line 269, in __init__
    self._init_builder()
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx/application.py", line 330, in _init_builder
    self.events.emit('builder-inited')
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx/events.py", line 103, in emit
    results.append(callback(self.app, *args))
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx_gallery/gen_gallery.py", line 284, in generate_gallery_rst
    seen_backrefs)
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx_gallery/gen_rst.py", line 328, in generate_dir_rst
    fname, target_dir, src_dir, gallery_conf, seen_backrefs)
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx_gallery/gen_rst.py", line 777, in generate_file_rst
    fname, intro)
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/site-packages/sphinx_gallery/backreferences.py", line 248, in _write_backreferences
    '%s.examples.new' % backref)
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/posixpath.py", line 94, in join
    genericpath._check_arg_types('join', a, *p)
  File "/Users/bane/anaconda3/envs/foo/lib/python3.7/genericpath.py", line 149, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'bool'

@GuillaumeFavelier
Copy link
Contributor Author

I will investigate locally. I didn't expect this to be honest

@banesullivan banesullivan merged commit 5188278 into master Nov 20, 2019
@banesullivan banesullivan deleted the glyph_clamping_range branch November 24, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants