-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename UniformGrid to ImageData #4518
Rename UniformGrid to ImageData #4518
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4518 +/- ##
==========================================
- Coverage 95.66% 95.66% -0.01%
==========================================
Files 107 107
Lines 21048 21060 +12
==========================================
+ Hits 20135 20146 +11
- Misses 913 914 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+100 for this change. As a PyVista user, I felt that the name UniformGrid was confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as with DefaultTheme
applies: do we want to update the namespace test names? We'd only run into problems if we remove UniformGrid
later, before restoring it as a vtkUniformGrid
subclass.
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as with
DefaultTheme
applies: do we want to update the namespace test names? We'd only run into problems if we removeUniformGrid
later, before restoring it as avtkUniformGrid
subclass.
Assuming an answer to leave it alone, in line with #4516 (comment).
Thanks @banesullivan, LGTM.
pyvists 0.43.0 renames UniformGrid to ImageData. See pyvista/pyvista#4518 for details. Renamed all instances of this for compatability with pyvista 0.43. Works with pyvista back to and including 0.40.
Deprecate
UniformGrid
to rename itImageData
to be better aligned with VTK data model.Resolves #3320
Please see #3320 for the original proposal and justification. The sooner we do this, the better.