Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Move more plotting VTK imports #4533

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Jun 12, 2023

I noticed some plotting imports slipped by my in my first iteration. I didn't catch these because, interestingly, they did not fail on import when libGL.so was missing

follow up to #4486

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #4533 (7968f93) into main (6c4db93) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4533      +/-   ##
==========================================
- Coverage   95.71%   95.71%   -0.01%     
==========================================
  Files         107      107              
  Lines       21066    21066              
==========================================
- Hits        20164    20163       -1     
- Misses        902      903       +1     

@banesullivan banesullivan changed the title Move more plotting VTK imports [HOTFIX] Move more plotting VTK imports Jun 12, 2023
@banesullivan banesullivan merged commit 24833c1 into main Jun 12, 2023
23 checks passed
@banesullivan banesullivan deleted the maint/plotting-imports branch June 12, 2023 14:58
@banesullivan banesullivan mentioned this pull request Jun 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant