Keep Plotter open for trame client view and connect axes widget #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banesullivan
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4547 +/- ##
==========================================
- Coverage 95.82% 95.72% -0.10%
==========================================
Files 127 127
Lines 21095 21104 +9
==========================================
- Hits 20214 20202 -12
- Misses 881 902 +21 |
tkoyama010
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Since I did not fully understand the code changes, I only verified that the test code is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plotter was automatically closing with the Trame client view -- these changes fix that
Also resolves #4130 -- these changes have to come together