-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve naming consistency #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many docstrings and comments it's still scalar
, not scalars
, that's used. That's definitely minor, but somewhat inconsistent. Maybe worth running sed -e 's/ scalar / scalars /'
over it.
Co-Authored-By: Simon Frei <freisim93@gmail.com>
Co-Authored-By: Simon Frei <freisim93@gmail.com>
@imsodin, thanks for the review! And thanks for catching my sloppy copy/paste errors - that's what happens when I work on this stuff late at night |
@imsodin, I just committed a change that updates the docstrings use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imsodin, thanks for the review! And thanks for catching my sloppy copy/paste errors - that's what happens when I work on this stuff late at night
I hope you don't take my remarks as criticism - I would be surprised if there wasn't any ;)
I am approving this, but I only skimmed (briefly) through it. However I think any remaining issues should be cosmetic and more reviewer time is better spent on functional stuff.
Oh, I definitely don't - your feedback is much appreciated! I am awful at catching my own mistakes these days.
Fair - I think all is good at this point. @GuillaumeFavelier, it would be great to have your eyes on this and perhaps use this PR as a place to implement to the decorator in #469 |
Resolve #429 to improve naming consistency for
*_scalars
and*_array
. This should be good to go and has deprecation warnings for the old methods to keep backward compatibility.@pyvista/developers, anyone have time to double-check all of this? This needs to land before the
0.23.0
release.