Add GeoVista integration test #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4568 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 127 127
Lines 21357 21357
=======================================
Hits 20454 20454
Misses 903 903 |
bjlittle
reviewed
Jun 24, 2023
|
@tkoyama010 Hmmmm the Never seen that before, you? It almost seems like the test report isn't being sent to |
|
@bjlittle I don't understand why, but waiting is often the answer :) |
banesullivan
approved these changes
Jun 27, 2023
|
No need to worry above coverage here |
|
As this is CI PR, it is considered to be outside the 24-hour rule. Thank you all for your cooperation. |
|
@tkoyama010 @banesullivan @akaszynski Awesome, thanks so much guys for banking this PR! 🍻 Looking forward to meeting you all at SciPy! |
|
@bjlittle Thank you. Let's go drinking during SciPy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We should add GeoVista to our integration tests to make sure we account for how it uses PyVista when changing our API.
Ping @bjlittle
relate to #3967
resolves #4565
Details