Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default color to lightblue for document theme #4574

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Jun 25, 2023

The default tan color for the document theme has fallen out of my favor and IMO looks dated -- it's time we freshen things up, and this times well with the defaule theme changing to be Document in #4516

Some history: the original tan color was chosen somewhat arbitrarily in 4583baf and was first orange in a8e5a8b.

I'd appreciate feedback on this and suggestions for other, perhaps better default colors for the document theme.

Maybe it makes sense to use Matplotlib's first color in their default cycler #1f77b4

tan (#D2B48C) lightblue (#ADD8E6) MPL's default #1f77b4
screenshot (28) screenshot (29) screenshot (30)
screenshot (33) screenshot (32) screenshot (31)
screenshot (34) screenshot (35) screenshot (36)

Personally, I think lightblue (#ADD8E6) looks the best all around. Not too light or washed out and not dark.

@github-actions github-actions bot added documentation Anything related to the documentation/website enhancement Changes that enhance the library labels Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #4574 (b10e1e2) into main (518f322) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4574   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         127      127           
  Lines       21357    21357           
=======================================
  Hits        20454    20454           
  Misses        903      903           

@akaszynski
Copy link
Member

I also feel that lightblue looks the best, especially considering how these look with black edges.

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blue is always better 😁

@bjlittle
Copy link
Contributor

FWIW I vote for light blue too 👍

@akaszynski akaszynski merged commit b672859 into main Jun 26, 2023
25 checks passed
@akaszynski akaszynski deleted the feat/default-color branch June 26, 2023 16:50
@banesullivan
Copy link
Member Author

Well alright! I didn't expect this to be embraced so enthusiastically and quickly... suppose I'm not the only one who was tired of tan

@banesullivan banesullivan mentioned this pull request Jun 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants