Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3D objects not being displayed in example of save_graphic #4586

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

tkoyama010
Copy link
Member

Overview

resolves #4584

Main PR
image image

Details

  • None

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #4586 (213d51f) into main (54e75aa) will decrease coverage by 2.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4586      +/-   ##
==========================================
- Coverage   95.77%   93.53%   -2.24%     
==========================================
  Files         127      127              
  Lines       21351    21354       +3     
==========================================
- Hits        20448    19974     -474     
- Misses        903     1380     +477     

@adeak
Copy link
Member

adeak commented Jun 27, 2023

Which change fixes the issue? Is it the render step that was missing before saving? We might consider pointing that out in the examples, or even making it an optional feature of the export.

@tkoyama010 tkoyama010 marked this pull request as draft June 27, 2023 07:18
@tkoyama010
Copy link
Member Author

tkoyama010 commented Jun 27, 2023

I began to think that it would be user-friendly to follow the screenshot approach. Please give me some time to consider this.

Examples
--------
>>> import pyvista
>>> sphere = pyvista.Sphere()
>>> plotter = pyvista.Plotter(off_screen=True)
>>> actor = plotter.add_mesh(sphere)
>>> plotter.screenshot('screenshot.png') # doctest:+SKIP

Edit: This seems to qualify as a bug.

@tkoyama010 tkoyama010 added bug Uh-oh! Something isn't working as expected. and removed documentation Anything related to the documentation/website labels Jun 27, 2023
@tkoyama010 tkoyama010 marked this pull request as ready for review June 28, 2023 17:27
@tkoyama010
Copy link
Member Author

Rendering during first-time rendering solved this issue.
img

@banesullivan banesullivan merged commit fad7493 into main Jun 29, 2023
25 checks passed
@banesullivan banesullivan deleted the doc/fix-example-of-save_graphic branch June 29, 2023 04:12
@banesullivan banesullivan mentioned this pull request Jun 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants