Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Docker image builds on PRs #4591

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Limit Docker image builds on PRs #4591

merged 1 commit into from
Jun 28, 2023

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Jun 27, 2023

We're publishing too many docker images (on for every PR). This changes it to only run on a PR if the branch name starts with docker.

Intentionally using maint/* here to make sure it skips

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #4591 (5d0b0e3) into main (518f322) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4591   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         127      127           
  Lines       21357    21357           
=======================================
  Hits        20454    20454           
  Misses        903      903           

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to not ship on each commit to the main branch.

@banesullivan
Copy link
Member Author

banesullivan commented Jun 27, 2023

as it stands, this still builds for every commit on main

@banesullivan banesullivan merged commit deac153 into main Jun 28, 2023
25 checks passed
@banesullivan banesullivan deleted the maint/docker branch June 28, 2023 01:01
@banesullivan banesullivan mentioned this pull request Jun 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants