Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultipleLines example #4651

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Fix MultipleLines example #4651

merged 4 commits into from
Jul 15, 2023

Conversation

AndCotOli
Copy link
Contributor

Overview

Fixes #4388 by using the plotter to rotate the camera.

Details

Rotates the camera by 45 degrees and zooms out to see both lines.

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #4651 (330f3e1) into main (6396e16) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4651      +/-   ##
==========================================
+ Coverage   95.40%   95.47%   +0.07%     
==========================================
  Files         127      127              
  Lines       21193    21193              
==========================================
+ Hits        20219    20234      +15     
+ Misses        974      959      -15     

@tkoyama010
Copy link
Member

@AndCotOli
Thank you for your first contribution! Could you help us by following the steps in this section to make style corrections?
https://docs.pyvista.org/version/dev/extras/developer_notes.html#style-checking

@banesullivan
Copy link
Member

We could also use the pre-commit bot to fix the PR automatically

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great PR!

@tkoyama010 tkoyama010 merged commit 9a73733 into pyvista:main Jul 15, 2023
23 checks passed
banesullivan pushed a commit that referenced this pull request Jul 19, 2023
* Fix MultipleLines example

* Fix style

* Match previuos appearance

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>

---------

Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
@banesullivan banesullivan mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct the plot angles to show that there are multiple lines
3 participants