Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gaussian smoothing example #485

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Add gaussian smoothing example #485

merged 1 commit into from
Dec 2, 2019

Conversation

GuillaumeFavelier
Copy link
Contributor

Following #420 (review) this PR adds a gaussian smoothing example to the gallery to showcase @imsodin work.

Locally I obtain the following:

image

@GuillaumeFavelier GuillaumeFavelier added the example There's a great example/demo in this thread! label Dec 2, 2019
@GuillaumeFavelier GuillaumeFavelier self-assigned this Dec 2, 2019
@GuillaumeFavelier
Copy link
Contributor Author

What do you think @pyvista/developers, should I add/modify anything? Let me know if you have any suggestions.

akaszynski
akaszynski approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example looks excellent! I especially like your use of the multiple render windows to demonstrate the level of smoothing.

@akaszynski akaszynski merged commit e541d2c into master Dec 2, 2019
banesullivan
banesullivan reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@banesullivan banesullivan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome example! I have just a few suggestions

examples/01-filter/gaussian-smoothing.py Show resolved Hide resolved
examples/01-filter/gaussian-smoothing.py Show resolved Hide resolved
examples/01-filter/gaussian-smoothing.py Show resolved Hide resolved
@banesullivan
Copy link
Member

Oh whoops this was already merged...

banesullivan added a commit that referenced this pull request Dec 2, 2019
@banesullivan
Follow up #485
2e14f21
@banesullivan
Copy link
Member

I just pushed those suggestions to the master branch

@banesullivan banesullivan deleted the gaussian_smoothing_example branch December 11, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banesullivan banesullivan banesullivan left review comments

@akaszynski akaszynski akaszynski approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
example There's a great example/demo in this thread!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuillaumeFavelier @banesullivan @akaszynski