New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and fix connectivity
docs
#4872
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4872 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 130 130
Lines 21465 21476 +11
=======================================
+ Hits 20598 20609 +11
Misses 867 867 |
connectivity
docsconnectivity
docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for suggesting the correction, I do have one suggestion. The docstring Example section of connectivity seems a bit long in my mind. Could you move that content to examples/01-filter/connectivity.py
? For us, the docstring is an introduction to using the method by default in a simple way, and we would like to see a separate example page for more detailed usage.
Ok. I agree this is a better place for these. The examples have been moved with some edits / changes, and new, simpler, docstring examples added. See the updated PR Overview for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Overview
Follow up from #4824. Improve docs and include minor bug fixes.
Details
compute-volume
example to use the correctconnectivity
scalar_range
(percentages taken fromthreshold_percent
were previously incorrectly used)versionadded
directive andvariable_input
param (lists were previously formatted as a paragraph)scalar_range
(must be a sequence with two values) and add relevant test casesSee Also
section with relevant methods (methods are now also hyperlinked)examples/01-filter/connectivity.py
'specified'
mode where specifying an unused region id would raise an unexpectedKeyError
. The filter now correctly returns an empty mesh.PolyData.clean
where it would would raise an error when cleaning a mesh with points but no cells