Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OSError to more specific FileNotFoundError when needed #506

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Change OSError to more specific FileNotFoundError when needed #506

merged 1 commit into from
Dec 17, 2019

Conversation

truenicoco
Copy link
Contributor

Fix #505

banesullivan
banesullivan approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @truenicoco, I believe this is an artifact of recently supporting Python 2.7 and FileNotFoundError not being introduced until Python 3.something - thanks for updating this as we no longer support 2.7!

@banesullivan
Copy link
Member

Also please ignore the failing "greetings" test - totally unrelated to your changes

@banesullivan banesullivan added this to the 0.23.0 milestone Dec 17, 2019
@banesullivan banesullivan merged commit aafeb31 into pyvista:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banesullivan banesullivan banesullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

FileNotFoundError should be raised instead of OSError
2 participants
@truenicoco @banesullivan