Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent q-key from binding to QtInteractor class #508

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Prevent q-key from binding to QtInteractor class #508

merged 1 commit into from
Dec 17, 2019

Conversation

banesullivan
Copy link
Member

Adress issue raised in pyvista/pyvista-support#86 (comment) by @akaszynski

Now the q-key will not bind to embedded widgets in Qt apps but will still close the BackgroundPlotter

akaszynski
akaszynski approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@banesullivan banesullivan added this to the 0.23.0 milestone Dec 17, 2019
@banesullivan banesullivan merged commit 3ad492a into master Dec 17, 2019
@banesullivan banesullivan deleted the patch/qt-stuff branch December 19, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@banesullivan @akaszynski