Add checkbox button #528
Merged
Add checkbox button #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
akaszynski
approved these changes
Jan 10, 2020
|
I can add it to the tests at least for coverage then |
banesullivan
requested changes
Jan 13, 2020
tests/test_widgets.py
Outdated
| func = lambda value: value # Does nothing | ||
| p.add_mesh(mesh) | ||
| p.add_checkbox_button_widget(callback=func) | ||
| p.clear_button_widgets() |
There was a problem hiding this comment.
Let's remove this line. The clear method should be called on close and if not, it will segfault resulting in a failed test
There was a problem hiding this comment.
I removed it but I think the same is done in all the other tests. In this case we should correct this
There was a problem hiding this comment.
ah yep, i totally missed that all the other tests are doing that. we should fix those too
banesullivan
approved these changes
Jan 13, 2020
|
I'll go ahead and merge this then I'll open a follow-up PR to fix the tests as suggested in #528 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for checkbox button. The
Animatelabel below is not part of the button but is given byadd_text()instead.To illustrate (inspired by Orbiting):
Source code: https://gist.github.com/GuillaumeFavelier/1bfa7ad2160d86b0814ed890dd7f27bc
I think this demo could be improved with floors or background image.