Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable depth peeling by default #529

Merged
merged 2 commits into from
Jan 13, 2020
Merged

enable depth peeling by default #529

merged 2 commits into from
Jan 13, 2020

Conversation

banesullivan
Copy link
Member

Resolve #527 by controlling depth peeling (#450) in the rcParams. Default is now enabled.

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will improve rendering for some of the models I use my closed source project. I agree with adding to rcParams. Thanks for adding that to the documentation.

@banesullivan
Copy link
Member Author

@GuillaumeFavelier, are you cool with this? I imagine it will only benefit mne-python

@banesullivan banesullivan added enhancement Changes that enhance the library proposed-change Something with regards to the API or internal structure is changing. labels Jan 13, 2020
@GuillaumeFavelier
Copy link
Contributor

GuillaumeFavelier commented Jan 13, 2020

Yes, I'm okay with it!

Depending on user feedback I can always change it locally and/or report in here 👍

@banesullivan banesullivan merged commit 74adbdd into master Jan 13, 2020
@GuillaumeFavelier
Copy link
Contributor

GuillaumeFavelier commented Jan 14, 2020

For now I have to disable the depth peeling in MNE, I noticed some artifacts in a use case with overlapping surfaces:

With depth peeling Without depth peeling
2020-01-14_1920x1080 2020-01-14_1920x1080

I tried different parameters (increasing the number of peels and decreasing the occlusion ratio) but I got no improvement.

To reproduce on mne-python/master:

$ MNE_3D_BACKEND=pyvista ipython --gui=qt
In [1]: run tutorials/source-modeling/plot_visualize_stc.py

I have to create a minimal working example using pyvista only to help isolate the issue but it's totally possible that there is something wrong in my code.

@banesullivan
Copy link
Member Author

Perhaps messing with the coincident topology options would help with that? Some details in #301 (comment)

@GuillaumeFavelier, can you save out those two surfaces as VTK files and post them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library proposed-change Something with regards to the API or internal structure is changing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to enable depth peeling by default
3 participants