Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a codeower to important files under .github/workflows #5312

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

tkoyama010
Copy link
Member

Overview

@banesullivan I added you to the testing-and-deployment.yml codeowner. If we merge this, we cannot merge the testing-and-deployment.yml changes without your approval.
We can add any other workflows you wish to add.

Details

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Dec 9, 2023
@banesullivan
Copy link
Member

Thanks @tkoyama010! I was just looking up how to do this. I'm a little concerned about noise from dependable PRs though

.github/CODEOWNERS Outdated Show resolved Hide resolved
@banesullivan
Copy link
Member

I'd like to go ahead and merge this but then raise an offline conversation, perhaps on Slack to see if there are other critical parts of code that people want to volunteer to "own". Some potential files:

  • pyvista/core/_vtk_core.py
  • pyvista/plotting/_vtk_gl.py
  • pyvista/plotting/_vtk.py
  • pyvista/trame/jupyter.py
  • pyvista/__init__.py
  • pyvista/_version.py

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #5312 (b8f3ed0) into main (ca415e5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5312   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         134      134           
  Lines       22712    22712           
=======================================
  Hits        21850    21850           
  Misses        862      862           

Copy link
Contributor

github-actions bot commented Dec 9, 2023

@github-actions github-actions bot temporarily deployed to pull request December 9, 2023 05:52 Inactive
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>
@tkoyama010 tkoyama010 changed the title Add a codeower to testing-and-deployment.yml Add a codeower to important files under .github/workflows Dec 9, 2023
@banesullivan banesullivan enabled auto-merge (squash) December 9, 2023 06:21
@github-actions github-actions bot temporarily deployed to pull request December 9, 2023 08:00 Inactive
@banesullivan banesullivan merged commit 18b3e63 into main Dec 9, 2023
27 checks passed
@banesullivan banesullivan deleted the maint/add-code-owner branch December 9, 2023 08:07
@banesullivan banesullivan mentioned this pull request Dec 14, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants