Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] fix combine filter for nested MultiBlock #535

Merged
merged 2 commits into from
Jan 30, 2020
Merged

[BUGFIX] fix combine filter for nested MultiBlock #535

merged 2 commits into from
Jan 30, 2020

Conversation

banesullivan
Copy link
Member

Previously, running the combine filter on a nest MultiBlock dataset would result in a stream of errors. This resolves that.

@banesullivan banesullivan added the priority-high This is a fairly serious issue/feature request that needs to be addressed. label Jan 15, 2020
@banesullivan banesullivan changed the title [Patch] fix combine filter for nested MultiBlock [BUGFIX] fix combine filter for nested MultiBlock Jan 15, 2020
@banesullivan banesullivan self-assigned this Jan 15, 2020
pyvista-bot
pyvista-bot approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@pyvista-bot pyvista-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice testing, LGTM!

@banesullivan banesullivan merged commit a1b1257 into master Jan 30, 2020
@banesullivan banesullivan deleted the patch/multi-combine branch February 6, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyvista-bot pyvista-bot pyvista-bot approved these changes

Assignees

@banesullivan banesullivan

Labels
priority-high This is a fairly serious issue/feature request that needs to be addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@banesullivan @pyvista-bot