Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify docstring style guide with numpydoc #5370

Merged

Conversation

tkoyama010
Copy link
Member

Overview

resolve #5198

Currently we are using the numpydoc linter and dropping the PEP8 docstring style guide in this PR.

Details

  • None

@tkoyama010 tkoyama010 linked an issue Dec 20, 2023 that may be closed by this pull request
@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (451f87f) 96.40% compared to head (ba24b84) 96.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5370   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         134      134           
  Lines       22826    22826           
=======================================
  Hits        22005    22005           
  Misses        821      821           

@tkoyama010
Copy link
Member Author

@pyvista-bot LGTM

Copy link
Contributor

@pyvista-bot pyvista-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because tkoyama010 said so in here :shipit:

@tkoyama010 tkoyama010 enabled auto-merge (squash) December 25, 2023 01:42
@tkoyama010 tkoyama010 merged commit b594aac into main Dec 25, 2023
25 checks passed
@tkoyama010 tkoyama010 deleted the maint/5198-clarify-docstring-length-in-contributingrst branch December 25, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify docstring length in CONTRIBUTING.rst
2 participants