Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve meshio support #559

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Improve meshio support #559

merged 2 commits into from
Jan 23, 2020

Conversation

keurfonluu
Copy link
Contributor

Writer

  • Added: support to polygons,
  • Added: raise AssertionError is any cell type is not supported by meshio.

Note

banesullivan
banesullivan approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @keurfonluu

@banesullivan banesullivan added bug-fix enhancement Changes that enhance the library labels Jan 23, 2020
@banesullivan banesullivan merged commit e5b012f into master Jan 23, 2020
@banesullivan banesullivan mentioned this pull request Jan 23, 2020
Open
@banesullivan banesullivan deleted the meshio branch February 6, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banesullivan banesullivan banesullivan approved these changes

Assignees
No one assigned
Labels
enhancement Changes that enhance the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keurfonluu @banesullivan