add file drop functionality to BackgroundPlotter #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really awesome!!! With this, it would be huge to have an object tree that can control the scalars array that is plotted, opacity, representation style, etc. This could get complicated real quick. |
|
I'll keep this open and add some of the features from |
banesullivan
changed the title
|
I tested and it works well for me! Let me know when you think it's ready for reviews. |
|
It’s ready now. I’ll add in the other features (feature tree) later. |
GuillaumeFavelier
approved these changes
Feb 2, 2020
akaszynski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackgroundPlotternow accepts dropped files. Right now, it just adds the mesh directly to the plotter using no kwargs. We need to add the option to have an object tree likepyvista-guiso we can change the way a mesh is plotted from within the GUI.