New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check variable assignments that immediately return #5911
Draft
tkoyama010
wants to merge
4
commits into
main
Choose a base branch
from
maint/ret
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Anything related to the documentation/website
maintenance
Low-impact maintenance activity
labels
Apr 12, 2024
tkoyama010
commented
Apr 12, 2024
@pyvista-bot LGTM |
pyvista-bot
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approving this PR because tkoyama010 said so in here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5911 +/- ##
==========================================
- Coverage 96.83% 96.81% -0.03%
==========================================
Files 139 139
Lines 24043 24033 -10
==========================================
- Hits 23283 23267 -16
- Misses 760 766 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Anything related to the documentation/website
maintenance
Low-impact maintenance activity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checks for variable assignments that immediately precede a
return
of the assigned variable.Note
https://docs.astral.sh/ruff/rules/unnecessary-assign/
Caution
Based on this comment, ignore checks for changes in the composition of the if statement.