-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing load
parameter to some example downloads
#6078
Merged
tkoyama010
merged 2 commits into
main
from
feat/5775-add-missing-load-parameter-to-some-example-downloads
May 14, 2024
Merged
Add missing load
parameter to some example downloads
#6078
tkoyama010
merged 2 commits into
main
from
feat/5775-add-missing-load-parameter-to-some-example-downloads
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pyvista-bot LGTM |
user27182
requested changes
May 14, 2024
Co-authored-by: user27182 <89109579+user27182@users.noreply.github.com>
user27182
approved these changes
May 14, 2024
pyvista-bot
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approving this PR because tkoyama010 said so in here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
- Coverage 96.99% 96.98% -0.01%
==========================================
Files 141 141
Lines 24641 24641
==========================================
- Hits 23900 23899 -1
- Misses 741 742 +1 |
tkoyama010
deleted the
feat/5775-add-missing-load-parameter-to-some-example-downloads
branch
May 14, 2024 06:07
tkoyama010
added
bug
Uh-oh! Something isn't working as expected.
and removed
enhancement
Changes that enhance the library
labels
May 14, 2024
tkoyama010
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
resolve #5775.
Details