Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing load parameter to some example downloads #6078

Merged

Conversation

tkoyama010
Copy link
Member

Overview

resolve #5775.

Details

  • None

@tkoyama010 tkoyama010 linked an issue May 14, 2024 that may be closed by this pull request
@tkoyama010 tkoyama010 enabled auto-merge (squash) May 14, 2024 01:49
@tkoyama010
Copy link
Member Author

@pyvista-bot LGTM

pyvista/examples/downloads.py Outdated Show resolved Hide resolved
pyvista/examples/downloads.py Outdated Show resolved Hide resolved
pyvista/examples/downloads.py Outdated Show resolved Hide resolved
Co-authored-by: user27182 <89109579+user27182@users.noreply.github.com>
@tkoyama010 tkoyama010 requested a review from user27182 May 14, 2024 02:07
Copy link
Contributor

@pyvista-bot pyvista-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because tkoyama010 said so in here :shipit:

@pyvista-bot pyvista-bot added the enhancement Changes that enhance the library label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (59822ee) to head (9fc1886).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6078      +/-   ##
==========================================
- Coverage   96.99%   96.98%   -0.01%     
==========================================
  Files         141      141              
  Lines       24641    24641              
==========================================
- Hits        23900    23899       -1     
- Misses        741      742       +1     

@tkoyama010 tkoyama010 merged commit 5b6edfd into main May 14, 2024
30 checks passed
@tkoyama010 tkoyama010 deleted the feat/5775-add-missing-load-parameter-to-some-example-downloads branch May 14, 2024 06:07
@tkoyama010 tkoyama010 added bug Uh-oh! Something isn't working as expected. and removed enhancement Changes that enhance the library labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing load parameter to some example downloads
3 participants