Skip Vale checks for large diffs (more than 300 files changed)
#6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6116 +/- ##
==========================================
- Coverage 96.99% 96.99% -0.01%
==========================================
Files 141 141
Lines 24666 24666
==========================================
- Hits 23925 23924 -1
- Misses 741 742 +1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6116 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 141 141
Lines 24666 24666
=======================================
Hits 23925 23925
Misses 741 741 |
tkoyama010
approved these changes
May 24, 2024
tkoyama010
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit 4a3db4a.
tkoyama010
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to resolve failed checks associated with
Valefor #5718. If that PR is approved, then this PR could be merged just before, and then reverted right after #5718 is merged.The issue is with
reviewdogspecifically, which might be resolved withreviewdog==0.17.4. See reviewdog/reviewdog#1696.The current version of Vale is pinned to 2.9.5, see #5109. This version uses
reviewdog==0.17.0. I tried unpinning Vale here:https://github.com/pyvista/pyvista/actions/runs/9217324917/job/25359117083?pr=5718
This updates Vale to 3.4.2 but still uses
reviewdog==0.17.0, unfortunately, and still fails.So, this PR disables Vale altogether.