Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3-lights illumination #882

Merged
merged 5 commits into from
Sep 7, 2020
Merged

3-lights illumination #882

merged 5 commits into from
Sep 7, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Sep 3, 2020 •
edited

This PR offers an alternative 'raymond' lighting system based on Raymond Maple work in Mayavi.

I don't know what is the best way to integrate this in PyVista so I started with BasePlotter.__init__() with an illumination parameter. This is still a work in progress.

master PR
image image
image image

@GuillaumeFavelier GuillaumeFavelier added the enhancement Changes that enhance the library label Sep 3, 2020
@akaszynski
Copy link
Member

@GuillaumeFavelier,

BasePlotter works, but we might consider also adding a lighting property/method to the BasePlotter instead to be able to access and control lighting after initializing the plotter (especially useful for pyvistaqt.

@GuillaumeFavelier GuillaumeFavelier changed the title 🚧 3-lights illumination 3-lights illumination Sep 4, 2020
@GuillaumeFavelier
Copy link
Contributor Author

This is ready for reviews @pyvista/developers

akaszynski
akaszynski approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and I like how you can disable this a well.

In the future it would be great to have a lights property for both BasePlotter and Renderer to simplify this, but that's for another PR.

@GuillaumeFavelier GuillaumeFavelier merged commit c5d91cd into pyvista:master Sep 7, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the feat/lighting branch September 7, 2020 07:11
@akaszynski akaszynski mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
enhancement Changes that enhance the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GuillaumeFavelier @akaszynski