Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile targets for coverage #886

Merged

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Sep 9, 2020

This small PR brings some convenience targets to the Makefile similarly to pyvista/pyvistaqt#36.

I plan to work on fixing the codecov badge and improving the overall stats in a follow-up PR.

@GuillaumeFavelier GuillaumeFavelier added the enhancement Changes that enhance the library label Sep 9, 2020
@GuillaumeFavelier GuillaumeFavelier self-assigned this Sep 9, 2020
@GuillaumeFavelier
Copy link
Contributor Author

This is now ready for reviews @pyvista/developers

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like having a bunch of functions in the make file as well.

@GuillaumeFavelier GuillaumeFavelier merged commit 9718ddc into pyvista:master Sep 9, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the feat/makefile_coverage branch September 9, 2020 14:52
@akaszynski akaszynski mentioned this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants