Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage result #888

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

GuillaumeFavelier
Copy link
Contributor

Now the coverage stats are uploaded but not correct:

image

This PR fixes the tests path in Azure config file.

@GuillaumeFavelier GuillaumeFavelier added the enhancement Changes that enhance the library label Sep 9, 2020
@GuillaumeFavelier GuillaumeFavelier self-assigned this Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #888 into master will increase coverage by 18.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #888       +/-   ##
===========================================
+ Coverage   66.23%   84.56%   +18.33%     
===========================================
  Files           1       36       +35     
  Lines          77     8981     +8904     
===========================================
+ Hits           51     7595     +7544     
- Misses         26     1386     +1360     

@larsoner
Copy link
Contributor

larsoner commented Sep 9, 2020

Looks fixed!

@GuillaumeFavelier GuillaumeFavelier changed the title 🚧 Fix coverage result Fix coverage result Sep 9, 2020
@akaszynski
Copy link
Member

That's better. Thanks for fixing this!

@akaszynski akaszynski mentioned this pull request Sep 9, 2020
@GuillaumeFavelier GuillaumeFavelier merged commit dc59c66 into pyvista:master Sep 9, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the fix/azure branch September 9, 2020 16:44
@akaszynski akaszynski mentioned this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants