-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use f-strings where possible. #911
Conversation
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=======================================
Coverage 86.88% 86.89%
=======================================
Files 36 36
Lines 8985 8984 -1
=======================================
Hits 7807 7807
+ Misses 1178 1177 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I didn't look over every change but I assume the tests should catch any issues arising from this.
Thanks for doing this, @JevinJ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the change. We had a mix of old (%
) and newer format
methods and it's a good refactor to just use f-strings
now that they're supported.
I can merge this since it looks like the Python3.5 checks won't be reported since we're not building those. Not sure why it's still requiring those... Let me know when you're good for me to merge this. |
I just turned off the 3.5 required checks in the branch protection rules |
Thanks, totally forgot about that. I'll do the same for |
@akaszynski Good to go. |
Overview
With #905, f-strings can be used.
Converts .format and % syntax to f-strings where possible, including docs.
Some of the conversion was automated so have some caution reviewing.