Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix axis problem on ParametricEllipsoid #948

Merged
merged 1 commit into from
Oct 22, 2020
Merged

馃悰 Fix axis problem on ParametricEllipsoid #948

merged 1 commit into from
Oct 22, 2020

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Oct 12, 2020

Overview

resolve #800

Details

test

@tkoyama010 tkoyama010 marked this pull request as ready for review October 12, 2020 14:15
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #948 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files          36       36           
  Lines        9044     9044           
=======================================
  Hits         7865     7865           
  Misses       1179     1179           

@banesullivan banesullivan changed the title 馃悰 resolve #800 馃悰 Fix axis problem on ParametricEllipsoid Oct 14, 2020
@akaszynski
Copy link
Member

Great work! Just ran through all the parametric geometry examples and it looks like this corrects the z-axis. Here's the Super Ellipsoid example

master

image

fix/translate-default-direction

image

@akaszynski
Copy link
Member

Here's another example using this branch:

import pyvista as pv

pseudosphere = pv.ParametricPseudosphere()
pseudosphere.plot(color="tan", smooth_shading=True, show_axes=True)

image

The master branch forces the major axis to be along the x axis. It's nice to have a uniform convention for all of our parametric and non-parametric geometry.

@akaszynski akaszynski merged commit 1c3cf24 into pyvista:master Oct 22, 2020
@tkoyama010 tkoyama010 deleted the fix/translate-default-direction branch October 22, 2020 23:24
@akaszynski akaszynski mentioned this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible axis problem on ParametricEllipsoid
3 participants