Feat/active tensors #969
Merged
Feat/active tensors #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructure: - Setting the active vectors to None now applies to both structures - Erroneous return values (<0) now throw an error and leave the ndarray in the same state as the VTK-array Modified the tests to query this behaviour Added support for SetActiveTensors, similar to SetActiveVectors
… VTK arrays and compare them.
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
- Coverage 86.99% 86.80% -0.20%
==========================================
Files 36 36
Lines 9066 9144 +78
==========================================
+ Hits 7887 7937 +50
- Misses 1179 1207 +28 |
akaszynski
approved these changes
Oct 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This branch fixes bugs related to #968 and additionally adds the possibility to set active tensors.
Details
Methods in pyvista/core/common.py were added and modified to check for return values of the SetActive* methods. Additional tests were added to test for correctness of the new methods and the former bugs of setting active vectors.