Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional methods to PlotterITK #980

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Conversation

akaszynski
Copy link
Member

PlotterITK Improvements

This PR adds a few methods and UI improvements to the PlotterITK class:

  • Specify point sizes
  • Specify camera position
  • UI collapsed by default
  • Added rotate (orbit) keyword arg.
  • Added bounds arg when showing.
  • Specify background color

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #980 into master will increase coverage by 2.06%.
The diff coverage is 85.36%.

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   87.10%   89.16%   +2.06%     
==========================================
  Files          36       37       +1     
  Lines        9165    11320    +2155     
==========================================
+ Hits         7983    10094    +2111     
- Misses       1182     1226      +44     

@akaszynski akaszynski added this to the Release 0.27.0 milestone Nov 3, 2020
Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test locally. Since this is ann "experimental feature" and I know you're heavily using it, seems good to merge to me

@banesullivan banesullivan merged commit 1866f3c into master Nov 7, 2020
@akaszynski akaszynski mentioned this pull request Nov 8, 2020
adeak added a commit to adeak/pyvista that referenced this pull request Nov 9, 2020
* upstream/master: (101 commits)
  Allow picking in notebook with ipyvtk (pyvista#996)
  Fix subplotting with ipyvtk_simple (pyvista#994)
  Use render window size (pyvista#995)
  version bump to 0.27.0 (pyvista#993)
  Add Docker Documentation (pyvista#992)
  Reorg Plotting Testing (pyvista#990)
  Allow Python 3.9 and Explain Building (pyvista#991)
  remove added xvfb line in init
  Revert "add ipyvtk-simple docs"
  add ipyvtk-simple docs
  add ipyvtk-simple docs
  remove viz of last picked cell after clicking outside the mesh (pyvista#984)
  Add widgets to examples gallery (pyvista#988)
  Implement ipyvtk  (pyvista#983)
  Add additional methods to PlotterITK (pyvista#980)
  get pop to behave like pop (pyvista#979)
  remove binding to our fly_to_mouse_position (pyvista#981)
  removed depreciated features (pyvista#978)
  Feat/unstr grid cell dict (pyvista#976)
  ensure scalarbar colors tracks the number of colors (pyvista#971)
  ...
@akaszynski akaszynski deleted the feat/improve_itk branch November 10, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants