Improve import speed #126
Merged
Improve import speed #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 98.43% 98.44%
=======================================
Files 8 8
Lines 641 644 +3
=======================================
+ Hits 631 634 +3
Misses 10 10 |
|
Pinging @larsoner (I know you're busy). |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
larsoner
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches vtk imports to either use
pyvista._vtkorvtkmodules. This results in a reduction in import time, but also permits the user to avoid including the entirevtklibrary when freezing the application withpyinstalleror another freezing library.It's slightly messy because we currently allow
pyvista>=0.29.0. Should we raise this to0.29.0in thesetup.py, we can avoid adding this in.