WIP: HiDPI #21
Closed
WIP: HiDPI #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try this out as soon as I can |
I've got a 4K screen I can work on. Once this is passing tests please ping me and I'll take a look. |
|
This probably needs to be fixed at the VTK end. If it's possible at the Python level we can backport it by copying their adapter py code, but it might require C++ changes. We'll see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Not working yet. The RenderWindow.SetSize(...) does not seem to take effect, so resolution is stuck at half on HiDPI screens. In the meantime, forcing
_pixel_ratio=1.at least fixes the interaction.@banesullivan do you have a HiDPI screen where you could see if it's possible to get HiDPI rendering to actually work on BackgroundPlotter? I'm not sure what's needed to get that working, but once it does, I think the workarounds here might not be necessary, or uncommenting the
_pixel_ratio = ...thing might make interactions work properly.