Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix version specifier #296

Merged
merged 3 commits into from
Jan 30, 2023
Merged

MAINT: Fix version specifier #296

merged 3 commits into from
Jan 30, 2023

Conversation

larsoner
Copy link
Contributor

Should fix failures seen like https://github.com/pyvista/pyvistaqt/actions/runs/4041478088/jobs/6948090794

      error in pyvistaqt setup command: 'python_requires' must be a string containing valid version specifiers; Invalid specifier: '>=3.7.*'

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #296 (ec6efbb) into main (03ff77f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files           8        8           
  Lines         670      670           
  Branches       82       82           
=======================================
  Hits          652      652           
  Partials       18       18           

@larsoner
Copy link
Contributor Author

This test has been spuriously failing:

_____________ ERROR at teardown of test_background_plotting_orbit ______________
tests/conftest.py:97: in check_gc
    assert len(after) == 0, msg
E   AssertionError: Not all objects GCed:
E     vtkWeakReference: []
E     vtkFloatArray: []

rather than restarting CIs now and in the future, I added a @pytest.mark.allow_bad_gc_pyside and a comment about it

@tkoyama010
Copy link
Member

Thanks @larsoner

@tkoyama010 tkoyama010 merged commit daa93d8 into pyvista:main Jan 30, 2023
@larsoner larsoner deleted the ver branch January 30, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants