💚 Add pycodestyle in CI

[tkoyama010]

Let's add pycodestyle in CI !

[codecov]

Codecov Report

Merging #45 into master will decrease coverage by 0.22%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   94.88%   94.66%   -0.23%     
==========================================
  Files           5        5              
  Lines         430      431       +1     
==========================================
  Hits          408      408              
- Misses         22       23       +1     

[GuillaumeFavelier]

I notice that the ouput of pycodestyle here is really close to the one in #46 (comment)

[GuillaumeFavelier]

Most of it (E501) can be resolved by a convention for the number of characters by line and whether to allow whitespace after : or not (E203).

Finally, I think (E731) can be solved by using a local function instead of a lambda.

[tkoyama010]

Most of it (E501) can be resolved by a convention for the number of characters by line and whether to allow whitespace after : or not (E203).

You are abosolutly right. But Black doesn't allow it and it is the most inflexible checker that we ultimately need to follow it. So let's add ignore option about it.

--max-line-length=88 --ignore="E203"

Finally, I think (E731) can be solved by using a local function instead of a lambda.

You are right thanks.

[tkoyama010]

This is self review 👀

[tkoyama010]

Hmm. pycodestyle doesn't recognize ignore option 😕

[GuillaumeFavelier]

Even without the "?

[tkoyama010]

Oh. It works! Thanks @GuillaumeFavelier 👍

[tkoyama010]

Does someone know how to fix codecov error ?

[GuillaumeFavelier]

54db8db covered it for me locally but it's just the patch anyway, the overall coverage is still above the threshold so +1 for me.

Thanks @tkoyama010

[tkoyama010]

@GuillaumeFavelier Thanks😇
It is ready for merge.

[GuillaumeFavelier]

Thank you @tkoyama010 !