Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Add GHA schedule #83

Merged
merged 1 commit into from Feb 13, 2021
Merged

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR adds a schedule for the GitHub Actions CIs. This will help to relieve the pain of #76 for example. By failing early, it draws attention on maintenance at least. What do you think @pyvista/developers ?

@GuillaumeFavelier GuillaumeFavelier self-assigned this Feb 13, 2021
@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #83 (23c5aa8) into master (b1faea7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           7        7           
  Lines         612      612           
=======================================
  Hits          602      602           
  Misses         10       10           

@akaszynski
Copy link
Member

That's a great idea. I recently ran into an issue when building one of my other builds that ran into an issue due to a numpy version change. It's a good idea to implement daily builds and I think this would be useful for pyvista as well. In fact, we need to move over some of our builds to github CI so we can reduce the time it takes to run CI by splitting up the tests between GitHub Actions and Azure Pipelines.

@GuillaumeFavelier GuillaumeFavelier merged commit 239a237 into pyvista:master Feb 13, 2021
@GuillaumeFavelier
Copy link
Contributor Author

In fact, we need to move over some of our builds to github CI

I'll be glad to help on this 👍

@akaszynski
Copy link
Member

That would great!

I'm thinking of moving the doc build over since we can upload the artifacts of each doc-build. Plus, there are github actions to upload docs to gh-pages (like github-pages-deploy-action). See https://github.com/pyansys/pymapdl/blob/master/.github/workflows/ci-build.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants