Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OSMesa on Windows #4

Closed
wants to merge 22 commits into from
Closed

Bump OSMesa on Windows #4

wants to merge 22 commits into from

Conversation

banesullivan
Copy link
Member

No description provided.

@banesullivan banesullivan changed the title Bump OSMesa Bump OSMesa on Windows Nov 16, 2022
@akaszynski
Copy link
Member

Will this be necessary with osmesa VTK wheels?

@banesullivan
Copy link
Member Author

This entire action will be unnecessary with the new OSMesa wheels. They will bundle OSMesa in them (there will also be "slim" variants that do not bundle though)

@banesullivan
Copy link
Member Author

FWIW, this action is used by a handful of non-VTK graphics projects too

@larsoner larsoner marked this pull request as ready for review March 28, 2023 14:41
@larsoner larsoner marked this pull request as draft March 28, 2023 14:41
@larsoner
Copy link
Collaborator

@banesullivan where did you get the updated DLL?

I'm guessing it needs some other DLL(s) that are not present. Have you tried using DependencyWalker on it? You can see how I've done it programatically for another repo here when I had to debug:

I could do something similar here if it would help figure out why the new DLL isn't working.

I have a vague recollection that this dependency chain is one reason I didn't update the MESA OpenGL DLL using the release version on the MESA website.

@larsoner
Copy link
Collaborator

For example this msys/pacman url suggests there are a bunch of other dependencies for 23.0.1 s. You'd probably need the whole chain if you used that or a similar version...

@banesullivan
Copy link
Member Author

This just isn't worth our time... closing.

But on a brighter note, VTK will soon publish VTK wheels with OSMesa embedded for Windows. See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10095

@banesullivan
Copy link
Member Author

FYI, with the new OSMesa wheels being published for linux already and soon for Windows, this action will no longer be needed for PyVista's tests and I will likely move to deprecate it or focus it entirely for the qt use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants