Add background mesh support #62
Conversation
* Added in tetgen background mesh resizing functionality * Pass in bgmeshfilename to enable to enable mesh resizing * Pass in bgmesh pyvista object to enable mesh resizing * Examples of usage and testing * Update code review commits - Remove deduplication of tets - Remove resorting of vertices order of tets - Added verbose printing of bgmin object - Moved mtr handling out of LoadArray - Added some temporary debugging lines in test_tetgen.py * some cleanups * ifixedit * address review --------- Co-authored-by: Dion Häfner <dion.haefner@simulation.science>
for more information, see https://pre-commit.ci
|
@akaszynski Hi Alex! I see you've already noticed the PR but I just linked the relevant issue it's associated with + fixed a minor pydoc linter issue. Would you mind taking a look at it again? Also, we added support for both passing in a bgmeshfilename and the bgmesh directly through a pyvista mesh but we weren't certain whether or not the bgmeshfilename feature would be necessary. Let me know if there's any changes we should make! |
|
cc: @dionhaefner |
|
Will do. Will be reviewed by this evening. |
Apologizes for the delay. Build was failing and bumping Made a handful of changes and commented out what appears to be debugging code and plotter setup, which reduced the test time. One note, it's a bit less verbose to generate a subgrid with: cell_center = grid.cell_centers().points
subgrid = grid.extract_cells(cell_center[:, 2] < 0)extract_cells supports boolean masks, and using cell_centers means you don't have to access the |
|
Another note: We can use cell_connectivity, avoiding the need for a loop and a temporary list within |
akaszynski
changed the title
|
LGTM! Thanks for the speedy review / edits. Glad to learn that cell connectivity could be used to get the tets instead as well. |
|
Awesome job! |
|
Wow, that was fast - thanks everyone! |
Adds the support for sizing func as mentioned in issue #59