-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Move *.dcm
Files to data
Subdirectory
#10
[BUGFIX] Move *.dcm
Files to data
Subdirectory
#10
Conversation
3dgallery data
…-data Add cylinder in crossflow dataset
Add pvd files from paraview data
First see comments in pyvista/pyvista#2460. Right now that PR isn't even downloading any data. But I think you are right that the pyvista downloading functionality does not handle folders well currently. It only works well with a zip file. You may need to zip this IMO, it is easiest to test this whole thing out using https://docs.pyvista.org/extras/vtk_data.html You can use your current PR branch to test locally. This means you don't need to have this PR merged to make sure it works right. Just make sure you clear your examples cache before testing. |
Fully agree. Most efficient to zip the files and certainly easier to download from pyvista. |
@MatthewFlamm @akaszynski Thank you! Apologies, as this is my first PR. I also notice this PR is trying to add |
I think you need to create a new branch from master:
|
`vtk.vtkDICOMImageReader` cannot parse non-dcm files in a folder.
daf1c73
to
abb8742
Compare
When pulling from upstream ( I decided instead to amend my local master (deleting the file), rebase |
Folders cannot be downloaded using the GitHub API, which is causing DICOM Reader tests to fail in `pyvista`. Instead, zip the folder. This will be unzipped when downloaded.
Were you planning on zipping this or leaving as is? |
I zipped it. It's in |
@pyvista/developers @akaszynski Would you please kindly review and let me know if this PR is okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
vtk.vtkDICOMImageReader
cannot parse non-dcm files in a folder. To fix this, place all*.dcm
files in a separatedata
subfolder.