Completely rewrote geometry handling #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
approved these changes
Oct 25, 2018
| @@ -65,6 +81,34 @@ def project_extents(extents, src_proj, dest_proj, tol=1e-6): | |||
| return geom_in_crs.bounds | |||
|
|
|||
|
|
|||
| def geom_dict_to_array_dict(geom_dict, coord_names=['Longitude', 'Latitude']): | |||
| """ | |||
| Converts a dictionary containing an geometry key to a dictionary | |||
|
|
||
| For array conversion the following conventions are applied: | ||
|
|
||
| * Any nan separated array are converted into a MultiPolygon |
philippjfr
force-pushed
the
geometry_improvements
branch
from
979e96c
to
0f87755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely overhauls handling of paths, polygons and geometries in GeoViews. First of all it introduces a
GeomDictionaryInterfacewhich can process shapely geometries in the form:{'geometry': <shapely.Geometry>, 'value': 1, 'index': 1, ...}This means that the
MultiInterfaceinterface can process lists of these objects, providing a native representation of geometries and value dimensions without relying on geopandas. Conversion from geopandas to this new format is as simple as:Secondly it provides utilities to convert all supported types of path/polygon data to this format, which hugely simplifies the projection operations since everything can now uniformly operate on shapely geometries.
Lastly this PR adds support for handling polygon holes, which has been a longstanding limitation.