Fixed hover tooltips for Curve and Path types #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: bug
|
Looks good to me, and would be very welcome! |
|
There is a real bokeh notebook test failure because the previous data included wrong hover label. Will have to rebuild. I've also added various unit tests to check the correct hover information is set. |
|
Looks good to me too and the tests have passed. Ready to merge? |
|
Yep, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dimensions that shouldn't be are appearing in the hover tooltips. Additionally on
CurvePlotthe NdOverlay dimension information isn't supplied at all. I've also made various fixes to make color and alpha option work correctly in batched mode.