Fixed saving to html and json in Python 3 #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
changed the title
|
Make sure to test this change with the archive functionality. If I remember right, there is code that needs to use the mime type to figure out how to encode the data (bytes vs strings). |
That's exactly the bit that was failing before I defined these. Will definitely test that. |
|
Ready once tests pass. |
|
Looks good. I'll merge now on the understanding that you did test this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979 which ended up throwing bugs in
Renderer.savein python3 when a string type was written to file. By defining the MIME type the encoding is applied correctly.Needs some tests before merging.