Add support for Layout/Grid titles in bokeh #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: feature
|
That looks good! Shame bokeh doesn't let you do this more directly. Make sure to test this in Chrome/Firefox/Safari and if you find it is working well, I am happy to merge. |
|
Ready to merge when tests pass. |
jlstevens
reviewed
Dec 18, 2016
| @@ -153,7 +154,43 @@ def sync_sources(self): | |||
|
|
|||
|
|
|||
|
|
|||
| class GridPlot(BokehPlot, GenericCompositePlot): | |||
| class CompositePlot(BokehPlot): | |||
|
|
|||
There was a problem hiding this comment.
Would be good to have a docstring explaining what this base class is for. Right now, everything CompositePlot does seems to be only needed by LayoutPlot. Any ideas what CompositePlot could be used for that isn't LayoutPlot?
There was a problem hiding this comment.
GridPlot, just below, but yes I'll add a docstring.
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I had suggested in #989 it is possible to add a Div as a title to a composite plot. This finally adds consistency in titles between matplotlib and bokeh backends for Layout and Grid plots.
Still needs tests.
Examples
Layout
Grid